Fix SDK Already Exists Detection #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous SDK Already Exists check failed upon testing in App Service Linux environments as there were instances of the old agent that broke my check.
New check looks for the "applicationinsights" package specifically under the "/home/site/wwwroot" path on Node versions > 8.9 (where the
pathsparameter was introduced).Tested this change detects the path of the user's SDK in both Windows and Linux App Services from multiple starting paths inside and outside of the "/home" path. Also ensured that the check fails as expected if the application deployed to the App Service does not include the
applicationinsightspackage.