Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS Graph queries don't follow pages #2490

Closed
tamirkamara opened this issue Aug 22, 2022 · 0 comments · Fixed by #2492
Closed

MS Graph queries don't follow pages #2490

tamirkamara opened this issue Aug 22, 2022 · 0 comments · Fixed by #2492
Assignees
@tamirkamara
Labels
api Composition Service API bug Something isn't working

Comments

@tamirkamara
Copy link
Collaborator

Describe the bug
MS graph implement paging but our queries don't iterate over them. If an identity has many permissions (above ~50) we don't fetch all of them which can cause false 403/permission denied errors.

This has recently started to happen in the E2E tests, specifically in the AAD enabled ones. The non-AAD ones work correctly because of how the permission results are ordered.
@tamirkamara tamirkamara added the bug Something isn't working label Aug 22, 2022
@tamirkamara tamirkamara self-assigned this Aug 22, 2022
@tamirkamara tamirkamara added the api Composition Service API label Aug 22, 2022
@tamirkamara tamirkamara added this to the Release 0.5 milestone Aug 22, 2022
@tamirkamara tamirkamara mentioned this issue Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamirkamara tamirkamara

Labels
api Composition Service API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Paging in ms graph queries microsoft/AzureTRE
1 participant
@tamirkamara