Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging in ms graph queries #2492

Merged
merged 10 commits into from
Aug 23, 2022
Merged

Paging in ms graph queries #2492

merged 10 commits into from
Aug 23, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2490

What is being addressed

MS Graph queries implement paging and we need to do the same.

How is this addressed

  • Continue to query as long as the result include a next link

@github-actions
Copy link

github-actions bot commented Aug 22, 2022

Unit Test Results

496 tests   494 ✔️  13s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit ce3366d.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:18 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:24 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:24 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:38 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:38 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:38 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 22, 2022 17:40 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:53 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:53 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:53 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 07:54 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 23, 2022 08:58 Inactive
@tamirkamara tamirkamara marked this pull request as ready for review August 23, 2022 09:34
@tamirkamara
Copy link
Collaborator Author

/test-force-approve
Many runs that are collective fine but none finished ok. https://github.com/microsoft/AzureTRE/actions/runs/2906358327

@tamirkamara tamirkamara enabled auto-merge (squash) August 23, 2022 10:23
@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 206f206)

(in response to this comment from @tamirkamara)

Copy link
Contributor

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ce3366d)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 1273b5c into main Aug 23, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2490-ms-graph-paging branch August 23, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS Graph queries don't follow pages
2 participants