Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple review resources in Airlock Review VM UI #2764

Closed
4 tasks done
jjgriff93 opened this issue Oct 20, 2022 · 1 comment · Fixed by #2883
Closed
4 tasks done

Support multiple review resources in Airlock Review VM UI #2764

jjgriff93 opened this issue Oct 20, 2022 · 1 comment · Fixed by #2883
Assignees
Labels
airlock api Composition Service API feature ui TRE UI

Comments

@jjgriff93
Copy link
Collaborator

jjgriff93 commented Oct 20, 2022

As a follow on from #2738 we should support multiple review user resources in the UI to create a screen like this: https://www.figma.com/file/Ncl8TJsFf2WKf3frrqTbtq/AzureTRE-OSS-UI?node-id=1293%3A27999

This will involve modifying the reviewUserResources property of the airlock request to include the reviewerId in the form of a dictionary:

"reviewUserResources": {
    "<user_object_id>": {
        "workspaceId": "XXX",
        "workspaceServiceId": "XXX",
        "userResourceId": "XXX"
    }
}

This will allow the UI to then filter for the signed-in user id and also list the other ids to show who else is reviewing.

The API will also need to be modified to only allow one review VM per user. On /Create-review-resource, the API should:

  • Check if the current signed in user has a resource already in the reviewUserResources dict
  • If so, do a call to get the status of the resource. If it is running and healthy, return 409 Conflict
  • If not, delete it and create a new one, then replace the userResource details in the request
  • Update UI
@jjgriff93
Copy link
Collaborator Author

  • Could improve migration by doing a look up of the resource and assigning the correct user to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airlock api Composition Service API feature ui TRE UI
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant