Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock UI: create review VM #2759

Closed
wants to merge 14 commits into from
Closed

Conversation

jjgriff93
Copy link
Collaborator

@jjgriff93 jjgriff93 commented Oct 19, 2022

Resolves

#2738

What is being addressed

Adds ability to deploy a review Vm in airlock review UI and open to view airlock request data securely in the review workspace

How is this addressed

  • Redesigned review experience as multi-step modal
  • Implemented create-review-vm endpoint
  • Display relevant resource state (created, not created, creating)
  • Added workspace scope option to componentManager hook so we can check for updates on resource that's in a different workspace to the current context (needed for import review Vms that reside in a different workspace)
  • Changed create-review-vm api endpoint to return airlock request as well as create vm operation to reduce calls and latency on front-end and potential state mismatch

image

image

image

Note: this only supports single review VMs currently. A follow-up story adds support for multiple reviewers' Vm resources: #2764

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Unit Test Results

518 tests   518 ✔️  13s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 3b8c2d3.

♻️ This comment has been updated with latest results.

api_app/_version.py Outdated Show resolved Hide resolved
@jjgriff93 jjgriff93 enabled auto-merge (squash) October 20, 2022 11:37
Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3289985464 (with refid 5f10e2ca)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 enabled auto-merge (squash) October 20, 2022 13:30
@jjgriff93
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre5f10e2ca)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3290609690)

@github-actions
Copy link

Destroying branch test environment (RG: rg-tree1a3d597)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3290609690)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tree1a3d597)

@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3290628285 (with refid 5f10e2ca)

(in response to this comment from @jjgriff93)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre5f10e2ca)

@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3290888919 (with refid 5f10e2ca)

(in response to this comment from @jjgriff93)

@jjgriff93
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

Destroying branch test environment (RG: rg-tree1a3d597)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3291549099)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tree1a3d597)

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre5f10e2ca)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3291549099)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre5f10e2ca)

@jjgriff93 jjgriff93 closed this Oct 21, 2022
auto-merge was automatically disabled October 21, 2022 10:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants