Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea: Recover soft-deleted secret #1777

Conversation

tanya-borisova
Copy link
Contributor

PR for issue #1760

What is being addressed

Due to:

  • purge protection being enabled on keyvault in some environment (e.g. main E2E tests in CI), and
  • Terraform purging secrets while deleting them (enabled by default),
    E2E tests are failing on main because secrets can't be purged.

This PR changes settings for azurerm Terraform provider, so that it does no longer purge secrets while deleting them, and restores soft-deleted secrets.
So secrets will be merely soft-deleted but never purged, consecutive runs of E2E tests will be restoring and using previously deleted secrets.

This was tested in a dev environment with enabled purge protection via running E2E several consecutive times.

@tanya-borisova tanya-borisova linked an issue May 4, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 4, 2022

Unit Test Results

0 files   - 1  0 suites   - 1   0s ⏱️ - 4m 13s
0 tests  - 4  0 ✔️  - 1  0 💤 ±0  0  - 3 

Results for commit cb1ec0a. ± Comparison against base commit 3d96600.

This pull request removes 4 tests.
test_shared_services ‑ test_create_shared_service[tre-shared-service-gitea]
test_shared_services ‑ test_create_shared_service[tre-shared-service-nexus]
test_shared_services ‑ test_patch_firewall
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace

♻️ This comment has been updated with latest results.

@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented May 4, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2271096199 (with refid 25ece6b6)

(in response to this comment from @tanya-borisova)

@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented May 5, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2274413299 (with refid 25ece6b6)

(in response to this comment from @tanya-borisova)

@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented May 5, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2274422721 (with refid 25ece6b6)

(in response to this comment from @tanya-borisova)

@tanya-borisova tanya-borisova merged commit a2f5c53 into main May 5, 2022
@tanya-borisova tanya-borisova deleted the tborisova/1760-failed-to-remove-gitea-shared-service-in-e2e branch May 5, 2022 08:33
@tanya-borisova tanya-borisova mentioned this pull request May 12, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to remove Gitea Shared Service in E2E
3 participants