-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitea: Recover soft-deleted secret #1777
Gitea: Recover soft-deleted secret #1777
Conversation
This reverts commit b662705.
…ys in Gitea, this didn't work
Unit Test Results0 files - 1 0 suites - 1 0s ⏱️ - 4m 13s Results for commit cb1ec0a. ± Comparison against base commit 3d96600. This pull request removes 4 tests.
♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2271096199 (with refid (in response to this comment from @tanya-borisova) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2274413299 (with refid (in response to this comment from @tanya-borisova) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2274422721 (with refid (in response to this comment from @tanya-borisova) |
PR for issue #1760
What is being addressed
Due to:
E2E tests are failing on main because secrets can't be purged.
This PR changes settings for azurerm Terraform provider, so that it does no longer purge secrets while deleting them, and restores soft-deleted secrets.
So secrets will be merely soft-deleted but never purged, consecutive runs of E2E tests will be restoring and using previously deleted secrets.
This was tested in a dev environment with enabled purge protection via running E2E several consecutive times.