[cost] Tagging Base workspace #1970

pedro-pelegrin-nttdata · 2022-06-03T09:38:08Z

Fixes #1896

What is being addressed

Tagging Base workspace with tre_id and tre_workspace_id

How is this addressed

Added locals.tf file with tre_core_tags
Added tags property per azure resource

ghost · 2022-06-03T09:38:21Z

All CLA requirements met.

joalmeid

At base workspace level the tags tre_id and tre_workspace_id = var.tre_resource_id are now applied including the wks rg

templates/workspaces/base/porter.yaml

templates/workspaces/base/terraform/variables.tf

templates/workspaces/base/terraform/locals.tf

templates/workspaces/base/terraform/workspace.tf

guybartal · 2022-06-06T07:21:15Z

make sure you run terraform fmt --recursive in templates folder

guybartal · 2022-06-06T07:28:53Z

please make sure you tag all base workspace azure services, for example Airlock services:

https://github.com/microsoft/AzureTRE/blob/c83ec6428d4f459ce95b77e000b59e55f90b4e5e/templates/workspaces/base/terraform/airlock/storage_accounts.tf

try to deploy a new workspace to validate all new created resources are with the correct tags.

guybartal · 2022-06-06T19:39:13Z

LGTM, just fix the PR description (core->workspace).

templates/workspaces/base/terraform/appserviceplan.tf

templates/workspaces/base/terraform/aad/variables.tf

templates/workspaces/base/terraform/airlock/eventgrid_topics.tf

templates/workspaces/base/terraform/airlock/variables.tf

templates/workspaces/base/terraform/network/locals.tf

tamirkamara · 2022-06-08T20:17:04Z

/test-extended

github-actions · 2022-06-08T20:17:23Z

🤖 pr-bot 🤖

⚠️ When using /test-extended on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @tamirkamara)

tamirkamara · 2022-06-08T20:18:01Z

/test-extended d98c508

github-actions · 2022-06-08T20:18:20Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2464128324 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

tamirkamara · 2022-06-09T04:41:18Z

/test-destroy-env

github-actions · 2022-06-09T04:42:01Z

Destroying PR test environment (RG: rg-tre9c37e34b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2465990940)

github-actions · 2022-06-09T04:58:54Z

PR test environment destroy complete (RG: rg-tre9c37e34b)

tamirkamara · 2022-06-15T07:45:53Z

/test-extended 50c79ea

github-actions · 2022-06-15T07:46:11Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2500624343 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

…s://github.com/pedro-pelegrin-nttdata/AzureTRE into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

eladiw · 2022-06-16T07:11:34Z

/test-destroy-env

github-actions · 2022-06-16T07:12:17Z

Destroying PR test environment (RG: rg-tre9c37e34b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2507361379)

github-actions · 2022-06-16T07:37:09Z

PR test environment destroy complete (RG: rg-tre9c37e34b)

tamirkamara · 2022-06-16T17:02:07Z

/test-extended 82f15f9

github-actions · 2022-06-16T17:02:43Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2510555507 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

tamirkamara · 2022-06-17T04:39:03Z

/test-extended b77766c

github-actions · 2022-06-17T04:39:19Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2513356766 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

github-actions · 2022-06-17T06:07:05Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2513356766 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

tamirkamara · 2022-06-17T06:38:32Z

/test-destroy-env

github-actions · 2022-06-17T06:39:33Z

Destroying PR test environment (RG: rg-tre9c37e34b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2513801808)

github-actions · 2022-06-17T06:58:06Z

PR test environment destroy complete (RG: rg-tre9c37e34b)

github-actions · 2022-06-17T07:13:39Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2513356766 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

tamirkamara · 2022-06-17T07:41:11Z

/test-extended 0bde637

github-actions · 2022-06-17T07:41:26Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2514084321 (with refid 9c37e34b)

(in response to this comment from @tamirkamara)

Tagging Base workspace

607f5d5

github-actions bot added the external PR from an external contributor label Jun 3, 2022

joalmeid requested review from LizaShak and joalmeid June 3, 2022 11:18

Fixed tre_workspace_id

c83ec64

joalmeid approved these changes Jun 3, 2022

View reviewed changes

joalmeid linked an issue Jun 3, 2022 that may be closed by this pull request

Tag Base workspace template in Terraform #1896

Closed

2 tasks

joalmeid requested a review from guybartal June 3, 2022 13:38

tamirkamara requested changes Jun 6, 2022

View reviewed changes

Formatting Terraform files

95e1e4b

guybartal approved these changes Jun 6, 2022

View reviewed changes

templates/workspaces/base/terraform/appserviceplan.tf Outdated Show resolved Hide resolved

tamirkamara requested changes Jun 7, 2022

View reviewed changes

tamirkamara changed the title ~~Tagging Base workspace~~ [cost] Tagging Base workspace Jun 7, 2022

pedro-pelegrin-nttdata added 2 commits June 7, 2022 15:22

[cost] Tagging base workspace fix

e1d4834

Removed unused variable in workspace

ab8996d

tamirkamara self-requested a review June 8, 2022 20:16

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

d98c508

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

0e4bf64

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

03b8810

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

50c79ea

pedro-pelegrin-nttdata added 4 commits June 15, 2022 09:05

Lint (pull_request)

17f52c9

Merge branch 'pedro-pelegrin-nttdata/3917_Tag_Base_workspace' of http…

224c1ed

…s://github.com/pedro-pelegrin-nttdata/AzureTRE into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

terraform files format

5f93ef6

Terraform validation change

140b738

pedro-pelegrin-nttdata and others added 2 commits June 16, 2022 09:09

Copied file from main repo

28ca699

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

82f15f9

microsoft deleted a comment from github-actions bot Jun 16, 2022

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

b77766c

Merge branch 'main' into pedro-pelegrin-nttdata/3917_Tag_Base_workspace

0bde637

tamirkamara approved these changes Jun 17, 2022

View reviewed changes

tamirkamara merged commit e75f26a into microsoft:main Jun 17, 2022

pedro-pelegrin-nttdata deleted the pedro-pelegrin-nttdata/3917_Tag_Base_workspace branch June 20, 2022 07:34

guybartal mentioned this pull request Jul 5, 2022

Tag Innereye workspace template in Terraform #1960

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cost] Tagging Base workspace #1970

[cost] Tagging Base workspace #1970

pedro-pelegrin-nttdata commented Jun 3, 2022 •

edited by tamirkamara

Loading

ghost commented Jun 3, 2022 •

edited by ghost

Loading

joalmeid left a comment

guybartal commented Jun 6, 2022

guybartal commented Jun 6, 2022

guybartal commented Jun 6, 2022

tamirkamara commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

tamirkamara commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

tamirkamara commented Jun 9, 2022

github-actions bot commented Jun 9, 2022

github-actions bot commented Jun 9, 2022

tamirkamara commented Jun 15, 2022

github-actions bot commented Jun 15, 2022

eladiw commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

tamirkamara commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

tamirkamara commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

tamirkamara commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

tamirkamara commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

[cost] Tagging Base workspace #1970

[cost] Tagging Base workspace #1970

Conversation

pedro-pelegrin-nttdata commented Jun 3, 2022 • edited by tamirkamara Loading

What is being addressed

How is this addressed

ghost commented Jun 3, 2022 • edited by ghost Loading

joalmeid left a comment

Choose a reason for hiding this comment

guybartal commented Jun 6, 2022

guybartal commented Jun 6, 2022

guybartal commented Jun 6, 2022

tamirkamara commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

tamirkamara commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

tamirkamara commented Jun 9, 2022

github-actions bot commented Jun 9, 2022

github-actions bot commented Jun 9, 2022

tamirkamara commented Jun 15, 2022

github-actions bot commented Jun 15, 2022

eladiw commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

tamirkamara commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

tamirkamara commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

tamirkamara commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

tamirkamara commented Jun 17, 2022

github-actions bot commented Jun 17, 2022

pedro-pelegrin-nttdata commented Jun 3, 2022 •

edited by tamirkamara

Loading

ghost commented Jun 3, 2022 •

edited by ghost

Loading