Enable purge protection #1973
Merged
Enable purge protection #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icrosoft/AzureTRE into tborisova/1830-enable-purge-protection
…-purge-protection
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-trec504da90)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2474148698) |
|
Destroying branch test environment (RG: rg-trec33bca33)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2474148698) |
|
Branch test environment destroy complete (RG: rg-trec33bca33) |
|
PR test environment destroy complete (RG: rg-trec504da90) |
|
/test-force-approve I can't test the deletion and recreation of the environment in CI, because it uses destroy_env_no_terraform.sh from main branch and not from mine. I have tested this quite a lot on development TREs though so this should be okay. |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 2b169cd) (in response to this comment from @tanya-borisova) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1830
What is being addressed
Enable purge protection for all keyvaults used (see the issue linked).
How is this addressed
azurermto not purge soft deleted objects on destroy (all of them)azurermto recover soft deleted secrets (which is set to true by default)TF_VAR_keyvault_purge_protection_enabled