Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cost] Tag innereye Workspace Service in Terraform #1998

Conversation

pedro-pelegrin-nttdata
Copy link
Contributor

@pedro-pelegrin-nttdata pedro-pelegrin-nttdata commented Jun 8, 2022

Fixes #1894

What is being addressed

Tagging innereye Workspace Service with tre_id, tre_workspace_id and tre_workspace_service_id

How is this addressed

  • Added tre_workspace_tags to locals.tf
  • Added variable tre_workspace_tags to variables.tf
  • Added tags to tf files

@ghost
Copy link

ghost commented Jun 8, 2022

CLA assistant check
All CLA requirements met.

@github-actions github-actions bot added the external PR from an external contributor label Jun 8, 2022
@tamirkamara tamirkamara changed the title [cost] Tag innereye Workspace Service in Terraform (#1894) [cost] Tag innereye Workspace Service in Terraform Jun 8, 2022
Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take it offline with @pedro-pelegrin-nttdata

@guybartal
Copy link
Contributor

Did you try to deploy it?
looks like you use both local and variable in the same module but you never set the var,
if there's no hierarchy of modules you should simply use locals.

Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedro-pelegrin-nttdata thank you for going over all these services. Since all items here are workspace services I think you should use tre_workspace_service_tags as the name for the local/variable.

@guybartal
Copy link
Contributor

/test-extended 9dfd031

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2534744210 (with refid eae31f7a)

(in response to this comment from @guybartal)

Copy link
Contributor

@guybartal guybartal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guybartal guybartal dismissed tamirkamara’s stale review June 21, 2022 13:13

requested changes were made

@guybartal guybartal merged commit 090b747 into microsoft:main Jun 21, 2022
@pedro-pelegrin-nttdata pedro-pelegrin-nttdata deleted the pedro-pelegrin-nttdata/3918_Tag_Innereye_workspace branch June 21, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag innereye Workspace Service in Terraform
5 participants