Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory Identity with Application.ReadWrite.OwnedBy #2008

Merged

Conversation

ross-p-smith
Copy link
Contributor

PR for issue 1716

What is being addressed

There is a need for having an identity that can administer AAD Applications. Depending on the customer need, this identity will need either Application.ReadWrite.OwnedBy or Application.ReadWrite.All.

How is this addressed

  • The variable AUTO_WORKSPACE_APP_REGISTRATION determines this, and if true, the identity will be granted Application.ReadWrite.All and can write to any application as this is required by Terraform.
  • All users will need to run make auth and put this new identity in ./templates/core/.env

@ross-p-smith
Copy link
Contributor Author

/test-force-approve

This change does not get tested as it's a pre-requisite for TRE

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit f6c1618)

(in response to this comment from @ross-p-smith)

@ross-p-smith ross-p-smith merged commit 0385e91 into microsoft:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants