Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block WS Airlock storage acccounts from public network #2017

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

eladiw
Copy link
Contributor

@eladiw eladiw commented Jun 9, 2022

Fixes #2014

What is being addressed

The storage containers for the airlock, which resides inside the ws, were not restricted

How is this addressed

  • Added network rule

@eladiw eladiw added the airlock label Jun 9, 2022
@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2469542556 (with refid 2b312acd)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-extended

@eladiw eladiw requested a review from tamirkamara June 9, 2022 15:47
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2469552572 (with refid 2b312acd)

(in response to this comment from @eladiw)

@eladiw eladiw requested review from anatbal and LizaShak June 9, 2022 15:47
@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2469861145 (with refid 2b312acd)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-destroy-env

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Destroying PR test environment (RG: rg-tre2b312acd)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2469956595)

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

PR test environment destroy complete (RG: rg-tre2b312acd)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2470071340 (with refid 2b312acd)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2470478280 (with refid 2b312acd)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2470579890 (with refid 2b312acd)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-force-approve

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 6022191)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 9, 2022

/test-force-approve

Tested with another PR which disables AAD . and it worked. reverted this changed and forced approve.

@eladiw eladiw merged commit 4f0c65f into microsoft:main Jun 9, 2022
@eladiw eladiw deleted the fix/2014 branch June 9, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock - Restrict SA access
3 participants