-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block WS Airlock storage acccounts from public network #2017
Conversation
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2469542556 (with refid (in response to this comment from @eladiw) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2469552572 (with refid (in response to this comment from @eladiw) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2469861145 (with refid (in response to this comment from @eladiw) |
/test-destroy-env |
Destroying PR test environment (RG: rg-tre2b312acd)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2469956595) |
PR test environment destroy complete (RG: rg-tre2b312acd) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2470071340 (with refid (in response to this comment from @eladiw) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2470478280 (with refid (in response to this comment from @eladiw) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2470579890 (with refid (in response to this comment from @eladiw) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 6022191) (in response to this comment from @eladiw) |
Tested with another PR which disables AAD . and it worked. reverted this changed and forced approve. |
Fixes #2014
What is being addressed
The storage containers for the airlock, which resides inside the ws, were not restricted
How is this addressed