Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing MAKEFILE_DIR #2020

Merged
merged 6 commits into from
Jun 12, 2022
Merged

Fix missing MAKEFILE_DIR #2020

merged 6 commits into from
Jun 12, 2022

Conversation

tamirkamara
Copy link
Collaborator

Fixes #2018

What is being addressed

Some places were missing MAKEFILE_DIR and that made a parent makefile usage end with errors

How is this addressed

  • Add missing ones
  • Tiny fixes and ordering

@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

Unit Test Results

0 tests   - 4   0 ✔️  - 4   0s ⏱️ - 59m 21s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0 ❌ ±0 

Results for commit 343c586. ± Comparison against base commit b35d04a.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2469894475 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

ross-p-smith
ross-p-smith reviewed Jun 9, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2482523663 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

Destroying branch test environment (RG: rg-tre7d64f0eb)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2482581299)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tre7d64f0eb)

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre1a391e21)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2482581299)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre1a391e21)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2482669620 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

3 similar comments
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2482669620 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2482669620 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2482669620 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2483625524 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2483625524 (with refid 1a391e21)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 2336cab into main Jun 12, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2018-missing-makefile-dir-references branch June 12, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-p-smith ross-p-smith ross-p-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deploy-shared-services doesn't support running from a parent makefile
2 participants
@tamirkamara @ross-p-smith