Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tomcat url to download a fixed version #2024

Merged
merged 3 commits into from
Jun 12, 2022

Conversation

tamirkamara
Copy link
Collaborator

Fixes #2023

What is being addressed

Download Tomcat from a location that will hold our pinned version for a long time (the previous location saved only last 2 versions).

How is this addressed

  • As stated

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results

15 tests   - 7   15 ✔️  - 7   2s ⏱️ -6s
  4 suites +3     0 💤 ±0 
  4 files   +3     0 ±0 

Results for commit 17a9190. ± Comparison against base commit 4f0c65f.

This pull request removes 22 and adds 15 tests. Note that renamed tests count towards both.
test_provisioned_health_api ‑ test_health
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-nexus]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-nexus]
test_workspace_service_templates ‑ test_create_workspace_service_templates
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-azureml]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-devtestlabs]
…
org.apache.guacamole.auth.azuretre.AuthenticationProviderServiceTest ‑ validateTokenFailsWhenNoNeededRole
org.apache.guacamole.auth.azuretre.AuthenticationProviderServiceTest ‑ validateTokenSucceedWhenOwnerRole
org.apache.guacamole.auth.azuretre.AuthenticationProviderServiceTest ‑ validateTokenSucceedWhenResearcherRole
org.apache.guacamole.auth.azuretre.AuthenticationProviderServiceTest ‑ validateTokenThrowsWhenEmptyRole
org.apache.guacamole.auth.azuretre.AuthenticationProviderServiceTest ‑ validateTokenThrowsWhenExpiredToken
org.apache.guacamole.auth.azuretre.AuthenticationProviderServiceTest ‑ validateTokenThrowsWhenNoRole
org.apache.guacamole.auth.azuretre.AzureTREAuthenticationProviderTest ‑ authenticateUserFailsWhenNoAccessToken
org.apache.guacamole.auth.azuretre.AzureTREAuthenticationProviderTest ‑ authenticateUserFailsWhenNoPrefEmail
org.apache.guacamole.auth.azuretre.AzureTREAuthenticationProviderTest ‑ authenticateUserSucceed
org.apache.guacamole.auth.azuretre.AzureTREAuthenticationProviderTest ‑ getUserContextFailsWhenNotInstanceOfAuthUser
…

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
enough to see the docker build workflow pass, no need to deploy.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 2a3a278)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 17a9190)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 4a4e709 into main Jun 12, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2023-update-tomcat-url branch June 12, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guacamole tries to download a none-existent Tomcat version
2 participants