Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airlock processor networking (vnet integration and airlock subnet) #2040

Merged
merged 17 commits into from
Jun 16, 2022
Merged

Airlock processor networking (vnet integration and airlock subnet) #2040

merged 17 commits into from
Jun 16, 2022

Conversation

eladiw
Copy link
Contributor

@eladiw eladiw commented Jun 14, 2022 •
edited
Loading

Fixes #2038

What is being addressed

Adding:

  1. Airlock subnet in the core vnet
  2. Airlock processor is now vnet integrated
  3. Airlock storage subnet
  4. All PEs of the Airlock storage accounts are in the subnet created at (3)

Note to reviewer: Had to create a new subnet as the one in (1) has service delegation, hence PE are not possible

@eladiw eladiw force-pushed the feature/2038_vnetintegration branch from ca88fba to 79a36a9 Compare June 14, 2022 15:50
@eladiw
Copy link
Contributor Author

eladiw commented Jun 14, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2496486559 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 14, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2497075400 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw eladiw force-pushed the feature/2038_vnetintegration branch from 5f354b4 to caf8801 Compare June 15, 2022 06:27
@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2500244162 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2500401791 (with refid 9c763024)

(in response to this comment from @eladiw)

tamirkamara
tamirkamara approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of renames. not a must...

templates/core/terraform/airlock/airlock_processor.tf Outdated Show resolved Hide resolved
templates/core/terraform/network/network.tf Outdated Show resolved Hide resolved
anatbal
anatbal approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, questions and little comment

templates/core/terraform/airlock/airlock_processor.tf Show resolved Hide resolved
templates/core/terraform/airlock/eventgrid_topics.tf Outdated Show resolved Hide resolved
@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre9c763024)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2500473934)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre9c763024)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2500606579 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2500612866 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre9c763024)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2501184976)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre9c763024)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2501314927 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2509779410 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 16, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre9c763024)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2509835694)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre9c763024)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 16, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2509972039 (with refid 9c763024)

(in response to this comment from @eladiw)

eladiw added 16 commits June 16, 2022 19:20
@eladiw
Airlock networking, including:
731c36a 
1. Airlock subnet in the core vnet
2. Airlock processor is now vnet integrated
@eladiw
moving the airlock storage accounts to a dedicated subnet
c1afa0a
@eladiw
rename
f6d4959
@eladiw
rename env var
b6b1994
@eladiw
update version
3b04d61
@eladiw
Revert "rename env var"
38c0471 
This reverts commit caf88011fffdcb2212254573a0663c3ef9ebf4cf.
@eladiw
rename
f11b07d
@eladiw
adding private endpoint for all event grid topics
e595bfa
@eladiw
adding inbound rule to allow airlock processor to reach the workspaces
f638202
@eladiw
Adding an AirlockEventSubnet
9d2988a 
All eventgrids are in the AirlockEventSubnets
All airlock storage are in the AirlockStorageSubnet
The airlock function is in the AirlockProcessorSubnet
@eladiw
fix
db4b1ec
@eladiw
adding nsg link
5c8db42
@eladiw
moving dns zones
446cd4a
@eladiw
fix
9ea48a0
@eladiw
cidr fixes
2db4b6f
@eladiw
adding moved block
09abf59
@eladiw eladiw force-pushed the feature/2038_vnetintegration branch from 7caa22a to 09abf59 Compare June 16, 2022 16:20
@eladiw
Copy link
Contributor Author

eladiw commented Jun 16, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2510352376 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 16, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2510507228 (with refid 9c763024)

(in response to this comment from @eladiw)

@eladiw eladiw merged commit 0a4e0d4 into microsoft:main Jun 16, 2022
@eladiw eladiw deleted the feature/2038_vnetintegration branch June 16, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi left review comments

@tamirkamara tamirkamara tamirkamara approved these changes

@anatbal anatbal Awaiting requested review from anatbal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Airlock - Add subnet and VNet integration
4 participants
@eladiw @tamirkamara @anatbal @marrobi