Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airlock - API - approve/reject a request #2044

Merged
merged 12 commits into from
Jun 16, 2022
Merged

Airlock - API - approve/reject a request #2044

merged 12 commits into from
Jun 16, 2022

Conversation

anatbal
Copy link
Collaborator

@anatbal anatbal commented Jun 15, 2022

PR fixes issue #1840

What is being addressed

** testing will be addressed in a subsequential pr**

  • Implement the review endpoint which allows the user to approve/reject a request
  • Create a new object - an airlock review
  • Fixed exception to return 400 whenever validation fails
  • Since status is not an attribute of airlock review, renamed it and changed the history mechanism so it will be included only on airlock requests
  • Fix minor typos

@anatbal anatbal changed the title Feature/approve reject airlock Airlock - API - approve/reject a request Jun 15, 2022
damoodamoo
damoodamoo reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@damoodamoo damoodamoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - will leave @eladiw to review + approve - but nice work :)

eladiw
eladiw suggested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@eladiw eladiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

api_app/api/routes/airlock.py Outdated Show resolved Hide resolved
api_app/api/routes/airlock.py Outdated Show resolved Hide resolved
api_app/api/routes/airlock.py Outdated Show resolved Hide resolved
api_app/api/routes/airlock.py Show resolved Hide resolved
api_app/event_grid/helpers.py Outdated Show resolved Hide resolved
@anatbal
Copy link
Collaborator Author

anatbal commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2503740240 (with refid a901e2e5)

(in response to this comment from @anatbal)

@microsoft microsoft deleted a comment from github-actions bot Jun 15, 2022
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2503740240 (with refid a901e2e5)

(in response to this comment from @anatbal)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2503740240 (with refid a901e2e5)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2504209117 (with refid a901e2e5)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Jun 15, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-trea901e2e5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2504444026)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-trea901e2e5)

@anatbal
Copy link
Collaborator Author

anatbal commented Jun 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2504580751 (with refid a901e2e5)

(in response to this comment from @anatbal)

3 similar comments
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2504580751 (with refid a901e2e5)

(in response to this comment from @anatbal)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2504580751 (with refid a901e2e5)

(in response to this comment from @anatbal)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2504580751 (with refid a901e2e5)

(in response to this comment from @anatbal)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2504580751 (with refid a901e2e5)

(in response to this comment from @anatbal)

@eladiw
Copy link
Contributor

eladiw commented Jun 16, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-trea901e2e5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2510715097)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-trea901e2e5)

@anatbal
Copy link
Collaborator Author

anatbal commented Jun 16, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2510979814 (with refid a901e2e5)

(in response to this comment from @anatbal)

@eladiw
Copy link
Contributor

eladiw commented Jun 16, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2511048018 (with refid a901e2e5)

(in response to this comment from @eladiw)

@anatbal
Copy link
Collaborator Author

anatbal commented Jun 16, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-trea901e2e5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2511273800)

@eladiw eladiw merged commit f36cfb9 into microsoft:main Jun 16, 2022
@github-actions
Copy link

PR test environment destroy complete (RG: rg-trea901e2e5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoodamoo damoodamoo damoodamoo left review comments

@eladiw eladiw eladiw approved these changes

Assignees
No one assigned
Labels
airlock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anatbal @eladiw @damoodamoo @tamirkamara