Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable API health check of downstream services #2049

Merged
merged 5 commits into from
Jun 16, 2022

Conversation

tamirkamara
Copy link
Collaborator

Fixes #2048

What is being addressed

We want to disable the logic where the API pings downstream services to test an assumption that those cause timeouts in the system.
Preliminary tests showed that they sometimes those take a long time and some are probably blocking so making the server unresponsive to other requests.

How is this addressed

  • Disable downstream services health check

@tamirkamara tamirkamara changed the title Disable API health check logic Disable API health check of downstream services Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022

Unit Test Results

282 tests  +260   280 ✔️ +258   9s ⏱️ -5s
    1 suites ±    0       2 💤 +    2 
    1 files   ±    0       0 ±    0 

Results for commit 8afa81d. ± Comparison against base commit fa9e71a.

This pull request removes 22 and adds 282 tests. Note that renamed tests count towards both.
test_provisioned_health_api ‑ test_health
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-nexus]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-nexus]
test_workspace_service_templates ‑ test_create_workspace_service_templates
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-azureml]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-devtestlabs]
…
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_api_access.TestTemplateRoutesThatRequireAdminRights ‑ test_get_workspace_templates_requires_admin_rights
tests_ma.test_api.test_routes.test_api_access.TestTemplateRoutesThatRequireAdminRights ‑ test_post_user_resource_templates_requires_admin_rights
tests_ma.test_api.test_routes.test_api_access.TestTemplateRoutesThatRequireAdminRights ‑ test_post_workspace_service_templates_requires_admin_rights
tests_ma.test_api.test_routes.test_api_access.TestTemplateRoutesThatRequireAdminRights ‑ test_post_workspace_templates_requires_admin_rights
tests_ma.test_api.test_routes.test_api_access.TestUserResourcesOwnerOrResearcherRoutesAccess ‑ test_delete_user_resource_raises_403_if_user_is_not_workspace_owner_or_researcher
tests_ma.test_api.test_routes.test_api_access.TestUserResourcesOwnerOrResearcherRoutesAccess ‑ test_get_user_resource_raises_403_if_user_is_not_workspace_owner_or_researcher
tests_ma.test_api.test_routes.test_api_access.TestUserResourcesOwnerOrResearcherRoutesAccess ‑ test_get_user_resources_raises_403_if_user_is_not_researcher_or_owner_of_workspace
tests_ma.test_api.test_routes.test_api_access.TestUserResourcesOwnerOrResearcherRoutesAccess ‑ test_patch_user_resource_raises_403_if_user_is_not_workspace_owner_or_researcher
…

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2509177006 (with refid b0ec2f70)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara temporarily deployed to CICD June 16, 2022 13:25 Inactive
@tamirkamara tamirkamara marked this pull request as ready for review June 16, 2022 14:03
@tamirkamara
Copy link
Collaborator Author

/test-force-approve
All tests passed (pr run and branch run) but for some reason the check wasn't marked so had to force it.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b139341)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b139341)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 8afa81d)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 5557fc7 into main Jun 16, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2048-api-disable-health-checks branch June 16, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky api] Disable components check in the API health check
2 participants