-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable API health check of downstream services #2049
Conversation
Unit Test Results282 tests +260 280 ✔️ +258 9s ⏱️ -5s Results for commit 8afa81d. ± Comparison against base commit fa9e71a. This pull request removes 22 and adds 282 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2509177006 (with refid (in response to this comment from @tamirkamara) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit b139341) (in response to this comment from @tamirkamara) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit b139341) (in response to this comment from @tamirkamara) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 8afa81d) (in response to this comment from @tamirkamara) |
Fixes #2048
What is being addressed
We want to disable the logic where the API pings downstream services to test an assumption that those cause timeouts in the system.
Preliminary tests showed that they sometimes those take a long time and some are probably blocking so making the server unresponsive to other requests.
How is this addressed