Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding networking changes (Eventgrid to SB enablement) #2055

Merged
merged 27 commits into from
Jun 23, 2022
Merged

Adding networking changes (Eventgrid to SB enablement) #2055

merged 27 commits into from
Jun 23, 2022

Conversation

eladiw
Copy link
Contributor

@eladiw eladiw commented Jun 18, 2022 •
edited
Loading

Fixes #2099

  1. Update networking configuration:
  • Each airlock topic/system topic gets a system-assigned identity (user-assigned don't work for this purpose of enabling secured messages transfer for EG to SB)
  1. Each of the system assigned identities gets a SB Data Sender role assignment for the SB
  2. SB accepts connections from selected networks + allowed trusted MS services (EG is one of them)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 18, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2521238677 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 18, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tree88c1997)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2521401586)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tree88c1997)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 18, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2521459140 (with refid e88c1997)

(in response to this comment from @eladiw)

@LizaShak LizaShak self-requested a review June 19, 2022 09:14
@eladiw eladiw force-pushed the feature/1841_1842_approve_reject branch from a5edbb2 to f358aa8 Compare June 19, 2022 20:57
@eladiw
Adding support in the Airlock processor for Approve/Reject (Import an…
ae24fc9 
…d Export)
@eladiw
increase airlock processor version
b2eff61
@eladiw
adding missing deploy line
969acee
@eladiw
1. SB networking changes: a) allows the events subnet b) allow for Tr…
b9be70a 
…usted azure services

2. Added managed identity to the event grid topiccsc
3. Added SB sender role to the managed identity
4. bug fixes in the airlock processor
@eladiw
fix ws
907ed9f
@eladiw eladiw force-pushed the feature/1841_1842_approve_reject branch from f358aa8 to 907ed9f Compare June 20, 2022 17:17
@eladiw
Copy link
Contributor Author

eladiw commented Jun 20, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2530555888 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 20, 2022

/test-extended

@eladiw eladiw marked this pull request as ready for review June 20, 2022 23:34
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2544970057 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tree88c1997)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2548194843)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tree88c1997)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2548448748 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw eladiw changed the title Adding support in the Airlock processor for Approve/Reject Adding networking changes (Eventgrid to SB enablement) Jun 23, 2022
@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2548681619 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tree88c1997)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2548775010)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tree88c1997)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2548873868 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2549234146 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tree88c1997)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2549432657)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tree88c1997)

@eladiw
Copy link
Contributor Author

eladiw commented Jun 23, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2549622144 (with refid e88c1997)

(in response to this comment from @eladiw)

@eladiw eladiw merged commit 59733aa into microsoft:main Jun 23, 2022
@eladiw eladiw deleted the feature/1841_1842_approve_reject branch June 23, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara approved these changes

@LizaShak LizaShak LizaShak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event grid can't send messages over PE to SB
4 participants
@eladiw @anatbal @tamirkamara @LizaShak