Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ftp in airlock app #2059

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

tamirkamara
Copy link
Collaborator

Fixes #2058

What is being addressed

Ftp should be disabled in all app service based apps.

How is this addressed

  • Disable ftp access in Airlock app
  • Move the application insights connection string (as instrumentation key will be deprecated soon)

@tamirkamara tamirkamara requested a review from eladiw June 19, 2022 16:57
@github-actions
Copy link

github-actions bot commented Jun 19, 2022

Unit Test Results

0 tests   - 22   0 ✔️  - 22   0s ⏱️ -7s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ±  0 

Results for commit a9541f1. ± Comparison against base commit 3cf66c4.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2524821212 (with refid 4d98fcd5)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 16f4c60 into main Jun 20, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2058-airlock-disable-ftp branch June 20, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock app with FTP on
2 participants