Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workspace redirect uris when auto-aad is disabled #2100

Merged
merged 8 commits into from
Jun 24, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Jun 23, 2022

Fixes #1352

What is being addressed

We need to update a workspace API redirect-uris even when we don't create the app automatically (aka auto-aad).

How is this addressed

  • Use a script with azcli commands to do this in the base workspace bundle
  • Add the application admin identity as an owner of the workspace app that is created via a setup script (called in make auth)
  • Fix some redundant code in the makefile

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 5f6636f.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2549556271 (with refid b17bd588)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as ready for review June 23, 2022 15:44
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2550326716 (with refid b17bd588)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2553620765 (with refid b17bd588)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 7cd71dd into main Jun 24, 2022
@tamirkamara tamirkamara deleted the tamirkamara/1352-guacamole-url-update branch June 24, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App registration's redirect url should be set automatically when creating a workspace
2 participants