Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run extended-aad tests only on main #2102

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

We should prioritize non-aad tests in PR validation but keep running the full suite after merge to main.

How is this addressed

  • Remove the job running AAD tests from the reusable deployment workflow
  • Add extended_aad marker to the selector parameter passed when running on the main branch

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 364aaf4.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review June 23, 2022 15:07
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:10 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:14 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:46 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 23, 2022 15:47 Inactive
@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

Destroying branch test environment (RG: rg-tre2e3ee0ee)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2550363095)

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre580a6c42)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2550363095)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre580a6c42)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 364aaf4)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tre2e3ee0ee)

@tamirkamara tamirkamara merged commit 29d95ef into main Jun 23, 2022
@tamirkamara tamirkamara deleted the tamirkamara/fix-aad-tests-should-run-on-main branch June 23, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants