Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace app service SKU as top level parameter #2117

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

tamirkamara
Copy link
Collaborator

Fixes #2085

What is being addressed

Sometimes we like to change the default AppService Plan SKU that is deployed (like due to Azure capacity issues).

How is this addressed

  • Add the sku param in all places so that the api (and ui) will pick it up
  • reference the providers.tf file in porter's TF mixin for better caching

@github-actions
Copy link

github-actions bot commented Jun 26, 2022

Unit Test Results

2 tests   - 20   2 ✔️  - 20   1h 18m 58s ⏱️ + 1h 18m 49s
1 suites ±  0   0 💤 ±  0 
1 files   ±  0   0 ±  0 

Results for commit 3d2878a. ± Comparison against base commit bff9a7e.

This pull request removes 22 and adds 2 tests. Note that renamed tests count towards both.
test_provisioned_health_api ‑ test_health
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-nexus]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-nexus]
test_workspace_service_templates ‑ test_create_workspace_service_templates
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-azureml]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-devtestlabs]
…
test_workspace_services ‑ test_create_guacamole_service_into_aad_workspace
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:38 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:41 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:42 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 05:44 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:01 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:22 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD June 26, 2022 06:22 Inactive
@tamirkamara tamirkamara marked this pull request as ready for review June 26, 2022 07:41
@tamirkamara
Copy link
Collaborator Author

/test-force-approve
tested in the branch workflow to run both extended and extended_aad tests.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 3d2878a)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 9817de4 into main Jun 26, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2085-workspace-app-service-sku-param branch June 26, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept App Service Plan sku as a workspace parameter
2 participants