Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename event grid topics to force recreate #2120

Merged
merged 4 commits into from
Jun 26, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Part of a temporary resolution to #2106 that occurred when the current tre deployment doesn't include an identity on the event grid topics which seem to cause an issue in TF (tracked separately).

How is this addressed

  • Remove the force replace section as that caused errors in Azure (delete and immediate recreate with the same name)
  • Rename the topic resources on Azure so that TF will create new ones with identity from the start, which will avoid the issue.

@tamirkamara tamirkamara requested a review from eladiw June 26, 2022 07:49
@github-actions
Copy link

github-actions bot commented Jun 26, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit a2e102f.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2563483958 (with refid d68c6de1)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara changed the title Force rename of event grid topics Rename event grid topics to force recreate Jun 26, 2022
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2563617462 (with refid d68c6de1)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as ready for review June 26, 2022 09:11
@tamirkamara tamirkamara merged commit 103d959 into main Jun 26, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2116-rename-event-grid-topics branch June 26, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants