Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Airlock Manager Role - Part I #2349

Merged
merged 31 commits into from
Aug 2, 2022
Merged

Adding Airlock Manager Role - Part I #2349

merged 31 commits into from
Aug 2, 2022

Conversation

anatbal
Copy link
Collaborator

@anatbal anatbal commented Jul 26, 2022 •
edited
Loading

Part 1 of #2269

Fixes #2380

What is being addressed

  • Adding new airlock manager role
  • Allowing only airlock manager to review airlock request
  • Edit unit tests to work with the new role

@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

Unit Test Results

467 tests   465 ✔️  12s ⏱️
    1 suites      2 💤
    1 files        0 ❌

Results for commit e334656.

♻️ This comment has been updated with latest results.

@anatbal anatbal force-pushed the feature/airlock-manager-role branch from 8862457 to ecd559d Compare July 26, 2022 15:53
@anatbal anatbal marked this pull request as ready for review July 27, 2022 14:03
@anatbal anatbal requested a review from LizaShak July 27, 2022 14:03
@anatbal anatbal force-pushed the feature/airlock-manager-role branch from 6a1445e to e996ab4 Compare July 27, 2022 14:05
@anatbal
Copy link
Collaborator Author

anatbal commented Jul 28, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2753546656 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Jul 31, 2022

/test-extended

@anatbal anatbal temporarily deployed to CICD July 31, 2022 17:11 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 17:12 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 17:13 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 17:13 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 17:14 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 18:14 Inactive
@anatbal anatbal marked this pull request as draft August 1, 2022 13:01
@anatbal anatbal marked this pull request as ready for review August 2, 2022 07:51
@anatbal
Copy link
Collaborator Author

anatbal commented Aug 2, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2780499397 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Aug 2, 2022

/test-destroy-env

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Destroying PR test environment (RG: rg-tre85319da0)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2780579260)

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

PR test environment destroy complete (RG: rg-tre85319da0)

@anatbal
Copy link
Collaborator Author

anatbal commented Aug 2, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2780650792 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Aug 2, 2022

/test-destroy-env

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Destroying PR test environment (RG: rg-tre85319da0)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2781113370)

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

PR test environment destroy complete (RG: rg-tre85319da0)

@anatbal
Copy link
Collaborator Author

anatbal commented Aug 2, 2022

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2781258811 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Aug 2, 2022

/test-force-approve

Tests previously completed

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e334656)

(in response to this comment from @anatbal)

@anatbal anatbal merged commit ee23882 into microsoft:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizaShak LizaShak LizaShak approved these changes

@ross-p-smith ross-p-smith ross-p-smith approved these changes

Assignees
No one assigned
Labels
airlock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Airlock fields aren't ordered the same way in Swagger
4 participants
@anatbal @ross-p-smith @LizaShak @tamirkamara