Guacamole updates firewall with deployment pipeline

[tamirkamara]

Resolves #2206

What is being addressed

Guacamole workspace service configured its firewall rules by using a script which is now obsolete as we have a deployment pipeline that should be used.

How is this addressed

• Update the firewall shared service to support firewall network rules
• Update the Guacamole workspace service with a step to add a firewall rule
• Remove redundant bundle dockerfile.tmpl files as the standard one is enough
• Upgrade Terraform CLI version and AzureRM versions
• Firewall Terraform update around diagnostics to prevent repeat changes
• Various Terraform changes to keep the linter happy
• Update both bundle versions to 0.4.0 as this is not a minor change

[github-actions]

Unit Test Results

0 tests   - 5   0 ✔️  - 4   0s ⏱️ - 2h 23m 13s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0 ❌  - 1 

Results for commit 76d3c0c. ± Comparison against base commit cb29a21.

♻️ This comment has been updated with latest results.

[tamirkamara]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2753298341 (with refid d476a9dd)

(in response to this comment from @tamirkamara)

[damoodamoo]

LGTM!

[tamirkamara]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2754647476 (with refid d476a9dd)

(in response to this comment from @tamirkamara)

[tamirkamara]

/test-destroy-env

[github-actions]

Destroying PR test environment (RG: rg-tred476a9dd)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2755545978)

[github-actions]

Destroying branch test environment (RG: rg-treeeb73ede)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2755545978)

[github-actions]

Branch test environment destroy complete (RG: rg-treeeb73ede)

[github-actions]

PR test environment destroy complete (RG: rg-tred476a9dd)

[tamirkamara]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2755743200 (with refid d476a9dd)

(in response to this comment from @tamirkamara)

[marrobi]

@tamirkamara given the firewall is a shared service, how do I get these changes into an existing TRE deployment? Thanks.

[tamirkamara]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2768506910 (with refid d476a9dd)

(in response to this comment from @tamirkamara)

[tamirkamara]

@tamirkamara given the firewall is a shared service, how do I get these changes into an existing TRE deployment? Thanks.

@marrobi unfortunately this is a manual process. I added a note in the changelog.