Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tre start/stop operations in parallel #2394

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Aug 2, 2022

Resolves #2393

What is being addressed

make tre-start (and stop) take a while to run (10-15 mins) mostly because of the interaction with the firewall and application gateway. If we run the actions in parallel time could be halved.

How is this addressed

  • Run all commands as jobs and wait for them to finish

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Unit Test Results

0 tests   - 5   0 ✔️  - 4   0s ⏱️ - 2h 25m 0s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 1 

Results for commit 1b37f44. ± Comparison against base commit ee23882.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2783604337 (with refid 32ceeb4b)

(in response to this comment from @tamirkamara)

Copy link
Contributor

@tanya-borisova tanya-borisova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2784115529 (with refid 32ceeb4b)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara closed this Aug 2, 2022
@tamirkamara tamirkamara reopened this Aug 2, 2022
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2784486892 (with refid 32ceeb4b)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2784486892 (with refid 32ceeb4b)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
Something is stuck...

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b3c59be)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara closed this Aug 3, 2022
@tamirkamara tamirkamara reopened this Aug 3, 2022
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b3c59be)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara force-pushed the tamirkamara/2939-start-stop-in-parallel branch from b4e51ef to b3c59be Compare August 3, 2022 04:50
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b3c59be)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 1b37f44)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 9335e30 into main Aug 3, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2939-start-stop-in-parallel branch August 3, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel operations in tre stop/start
2 participants