Move failed airlock requests to "failed" state #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requests-to-failed-state
…ed the output binding is not called
…requests-to-failed-state # Conflicts: # airlock_processor/StatusChangedQueueTrigger/__init__.py
yuvalyaron
changed the title
yuvalyaron
commented
Aug 2, 2022
2 tasks
tamirkamara
changed the title
…alyaron-feature/1967-airlock-move-failed-requests-to-failed-state � Conflicts: � CHANGELOG.md
…alyaron-feature/1967-airlock-move-failed-requests-to-failed-state
tanya-borisova
approved these changes
Aug 4, 2022
…alyaron-feature/1967-airlock-move-failed-requests-to-failed-state � Conflicts: � api_app/_version.py
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2795607109 (with refid (in response to this comment from @yuvalyaron) |
yuvalyaron
deleted the
yuvalyaron-feature/1967-airlock-move-failed-requests-to-failed-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2268
Fixes #2339
What is being addressed
Failed airlock requests no longer get stuck on "submitted" status, instead, their status changes to "failed", along with an
error_messagefield that was added to the airlock request and describes what went wrong.How is this addressed
error_messagefield to airlock requests to describe why the request failed.StatusChangedQueueTrigger, the block wraps the main method and handles all exceptions.StatusChangedQueueTrigger- to publish the failed event from the function.AirlockInvalidContainerExceptionin airlock and added 2 exceptions that are more specific instead.