Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary bundles mirror Terraform providers #2446

Merged
merged 8 commits into from
Aug 14, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Aug 10, 2022

What is being addressed

When we execute a bundle (like via install action) it needs outside communication to terraform domains to initialize itself which isn't ideal (see the issue for more info).
This is part of #2353 which will be closed in a future PR.

How is this addressed

  • Call a terraform command to mirror providers locally at build time which will prevent any need for external communication at runtime
  • Prepare the firewall for dropping the terraform domains more easily in the future
  • Upgrade Terraform client to 1.2.6 and AzureRM to 3.16 in all the updated bundles
  • In the base workspace, run vnet operations sequentially to prevent AnotherOperation errors
  • Minor (unrelated) changes in E2E

@github-actions
Copy link

github-actions bot commented Aug 10, 2022

Unit Test Results

0 tests   - 5   0 ✔️  - 1   0s ⏱️ - 41m 14s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 4 

Results for commit df74e73. ± Comparison against base commit 1112904.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2833920153 (with refid c1ecbf69)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2833920153 (with refid c1ecbf69)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2835320142 (with refid c1ecbf69)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as ready for review August 11, 2022 04:21
@tamirkamara tamirkamara changed the title Primary bundles mirror Terraform plugins Primary bundles mirror Terraform providers Aug 11, 2022
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:50 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 06:52 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:06 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:07 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:07 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:07 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 07:09 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD August 11, 2022 08:09 Inactive
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2854743959 (with refid c1ecbf69)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
Tests are currently broken due to unrelated change, but passed on a branch before this change was introduced.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit df74e73)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit db86454 into main Aug 14, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2353-tf-mirror branch August 14, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants