Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Operations + UI Stability improvements #2530

Merged
merged 20 commits into from
Aug 31, 2022
Merged

My Operations + UI Stability improvements #2530

merged 20 commits into from
Aug 31, 2022

Conversation

damoodamoo
Copy link
Member

Resolves #2241

What is being addressed

  • Adds a new endpoint to the API to get 'my' operations - those initiated by the current user. This is a single call which executes quickly and I would say mitigates Workspace status temporarily incorrect #2104 as the operations are loading before the resource lists.
  • UI Updates:
    • Moved the api-calling logic for individual operations into the Item level rather than the collection level. This improves readability and prevents having to work with collections.
    • Improved error handling when an operation is invalid (bad data / unrecoverable issue in the backend), so it renders an error with the Op Id to help support staff clean up data.
    • Improved stability when locking/refreshing/removing resources. Moved away from a separate 'component actions' collection which was prone to edge cases of re-rendering to the components just subscribing to the operations list directly, and not mutating that collection.
    • Improved the callout message when an operation completes, to indicate what just happened.
    • The 'bell' icon now shows a mini progress bar underneath when there are running operations, in the same way the Azure Portal does.

image

image

image

@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Unit Test Results

497 tests  +492   495 ✔️ +494   15s ⏱️ - 1h 40m 34s
    1 suites ±    0       2 💤 +    2 
    1 files   ±    0       0  -     4 

Results for commit 33a369c. ± Comparison against base commit d9cd10b.

This pull request removes 5 and adds 497 tests. Note that renamed tests count towards both.
test_airlock ‑ test_airlock_import_flow
test_shared_services ‑ test_create_shared_service[tre-shared-service-gitea]
test_shared_services ‑ test_patch_firewall
test_workspace_services ‑ test_create_guacamole_service_into_aad_workspace
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

♻️ This comment has been updated with latest results.

@damoodamoo
Copy link
Member Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2957238980 (with refid cebecf84)

(in response to this comment from @damoodamoo)

ui/app/src/models/operation.ts Outdated Show resolved Hide resolved
api_app/api/routes/operations.py Outdated Show resolved Hide resolved
api_app/db/repositories/operations.py Show resolved Hide resolved
api_app/resources/strings.py Outdated Show resolved Hide resolved
api_app/api/routes/operations.py Outdated Show resolved Hide resolved
api_app/_version.py Outdated Show resolved Hide resolved
Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damoodamoo.

@damoodamoo
Copy link
Member Author

/test-force-approve
tests have run previously

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 33a369c)

(in response to this comment from @damoodamoo)

@damoodamoo damoodamoo merged commit 5083fbd into main Aug 31, 2022
@damoodamoo damoodamoo deleted the damoo/2241-my-ops branch August 31, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/my-operations endpoint
3 participants