Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp changes for porter show #2542

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2541

What is being addressed

Reduce Resource Processor call to porter show to save time. Even for a simple bundle this call is ~5 seconds

How is this addressed

  • Remove redundant call made after an execution (like install). For the firewall shared service this reduces the time by 4-5 minutes.
  • When RP needs to access outputs it now runs a command for that alone without listing the executions. For the firewall shared service this reduces 1-2 minutes.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 9229188.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2987355270 (with refid bc0f3dad)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2988470268 (with refid bc0f3dad)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) September 5, 2022 07:06
@tamirkamara tamirkamara merged commit 4f13752 into main Sep 5, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2451-rp-porter-show branch September 5, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource processor run "porter show" when it shouldn't
2 participants