Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy ui by default #2554

Merged
merged 10 commits into from
Sep 7, 2022
Merged

Deploy ui by default #2554

merged 10 commits into from
Sep 7, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2387

What is being addressed

UI has been an optional component

How is this addressed

  • Switch the UI deployment to opt-out (instead of in)
  • Add a small test to the smoke e2e marker that check's that the main UI page has been returned

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Unit Test Results

17 tests   17 ✔️  7s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 3ff1528.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:00 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 08:04 Inactive
@tamirkamara tamirkamara force-pushed the tamirkamara/2387-deploy-ui-default branch from 24c5266 to eb3adf0 Compare September 6, 2022 08:39
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2998729597 (with refid 93660a97)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:20 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 6, 2022 12:23 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:02 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:05 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:09 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:10 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:10 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:12 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 7, 2022 13:14 Inactive
Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was way more than I'd have thought, awesome work!

@tamirkamara tamirkamara merged commit 736c160 into main Sep 7, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2387-deploy-ui-default branch September 7, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default initial deployment experience should be to have the UI deployed
2 participants