Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix getting user resource templates #2644

Merged

Conversation

tanya-borisova
Copy link
Contributor

What is being addressed

In #2623, a bug slipped in: getting of user resource templates is now broken because a parameter is being passed in incorrectly.

@github-actions
Copy link

Unit Test Results

510 tests  +505   510 ✔️ +507   12s ⏱️ - 1h 44m 37s
    1 suites ±    0       0 💤 ±    0 
    1 files   ±    0       0  -     2 

Results for commit defad71. ± Comparison against base commit af8dbaa.

This pull request removes 5 and adds 510 tests. Note that renamed tests count towards both.
test_airlock ‑ test_airlock_import_flow
test_shared_services ‑ test_create_shared_service[tre-shared-service-gitea]
test_shared_services ‑ test_patch_firewall
test_workspace_services ‑ test_create_guacamole_service_into_aad_workspace
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3119004854 (with refid c0e3170c)

(in response to this comment from @tanya-borisova)

@tanya-borisova
Copy link
Contributor Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit defad71)

(in response to this comment from @tanya-borisova)

@tanya-borisova tanya-borisova merged commit ad33f64 into main Sep 24, 2022
@tanya-borisova tanya-borisova deleted the tborisova/bugfix-getting-user-resource-templates branch September 24, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants