Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Github secret names #2655

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Align Github secret names #2655

merged 5 commits into from
Sep 28, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

On Github we use different names for secrets compared with their .env names. This creates confusion and mistakes.

Migration

  1. Rename (recreate) secret MGMT_RESOURCE_GROUP to MGMT_RESOURCE_GROUP_NAME
  2. Rename (recreate) secret STATE_STORAGE_ACCOUNT_NAME to MGMT_STORAGE_ACCOUNT_NAME
  3. If you have used tfstate as the value in TF_STATE_CONTAINER, then delete this secret. If not, you need to rename it to TERRAFORM_STATE_CONTAINER_NAME

How is this addressed

  • Align Github secret names to the ones in the .env files
  • Apply a default for values we don't change often

Base automatically changed from tamirkamara/remove-actions-acr to main September 28, 2022 09:18
@tamirkamara tamirkamara marked this pull request as ready for review September 28, 2022 09:22
@github-actions
Copy link

github-actions bot commented Sep 28, 2022

Unit Test Results

17 tests  ±0   17 ✔️ ±0   7s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit b2ab468. ± Comparison against base commit bf071cd.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@tamirkamara tamirkamara enabled auto-merge (squash) September 28, 2022 09:29
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:30 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:33 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 09:37 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:01 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:03 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:05 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:08 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:10 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:11 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:11 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:11 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:11 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:11 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:11 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:13 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:32 Inactive
@tamirkamara tamirkamara temporarily deployed to CICD September 28, 2022 10:34 Inactive
@tamirkamara tamirkamara merged commit df15228 into main Sep 28, 2022
@tamirkamara tamirkamara deleted the tamirkamara/align-secret-names branch September 28, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants