Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doker env variables #2675

Merged
merged 9 commits into from
Oct 2, 2022
Merged

Remove doker env variables #2675

merged 9 commits into from
Oct 2, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Some deploy.sh scripts used docker registry environment variable which aren't really needed.

How is this addressed

  • Remove obsolete variables

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3167624169 (with refid d3ac151d)

(in response to this comment from @tamirkamara)

Base automatically changed from tamirkamara/fix-tf-provider-bug to main October 2, 2022 08:23
@tamirkamara tamirkamara marked this pull request as ready for review October 2, 2022 08:24
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3167892581 (with refid d3ac151d)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 3f382a8.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@tamirkamara tamirkamara enabled auto-merge (squash) October 2, 2022 09:24
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3168057304 (with refid d3ac151d)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 4d25270 into main Oct 2, 2022
@tamirkamara tamirkamara deleted the tamirkamara/remove-docker-env branch October 2, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants