Re-working Status Update Queue Message Handling #2700

damoodamoo · 2022-10-04T09:51:56Z

Resolves #2647

What's changed:

Sessions enabled on the status update queue - will re-create the queue on tre-deploy. This will enforce ordering of messages, using the operation id as the session id.
Changed the queue subscription mechanism to closely match the RP, and the doc samples.
Moved the queue subscription from a @repeat-every to a dedicated background thread, running continuously.

github-actions · 2022-10-04T09:52:43Z

Unit Test Results

515 tests 515 ✔️ 12s ⏱️
    1 suites     0 💤
    1 files     0 ❌

Results for commit ebc4cb0.

♻️ This comment has been updated with latest results.

damoodamoo · 2022-10-04T10:06:10Z

/test-extended

github-actions · 2022-10-04T10:06:29Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3181228287 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

tanya-borisova

Does adding session_id require any kind of migration plan for the queue?

damoodamoo · 2022-10-04T10:13:37Z

Does adding session_id require any kind of migration plan for the queue?

The queue will just recreate. I've called it out in the changelog, but there's no 'migration' possible really. just a case of making sure you deploy when the TRE is idle.

damoodamoo · 2022-10-04T11:03:26Z

/test-destroy-env

github-actions · 2022-10-04T11:03:59Z

Destroying PR test environment (RG: rg-treca83a86f)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3181582475)

github-actions · 2022-10-04T11:04:06Z

Destroying branch test environment (RG: rg-tre5a42259b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3181582475)

github-actions · 2022-10-04T11:04:08Z

Branch test environment destroy complete (RG: rg-tre5a42259b)

damoodamoo · 2022-10-04T11:09:17Z

/test-extended

github-actions · 2022-10-04T11:09:37Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3181620293 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

github-actions · 2022-10-04T11:20:19Z

PR test environment destroy complete (RG: rg-treca83a86f)

damoodamoo · 2022-10-04T11:34:51Z

/test-extended

github-actions · 2022-10-04T11:35:06Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3181777758 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

github-actions · 2022-10-04T14:01:40Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3181777758 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

damoodamoo · 2022-10-04T15:13:41Z

/test-destroy-env

github-actions · 2022-10-04T15:14:17Z

Destroying PR test environment (RG: rg-treca83a86f)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3183288912)

github-actions · 2022-10-04T15:14:32Z

Destroying branch test environment (RG: rg-tre5a42259b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3183288912)

github-actions · 2022-10-04T15:14:33Z

Branch test environment destroy complete (RG: rg-tre5a42259b)

damoodamoo · 2022-10-04T15:27:42Z

/test-extended

github-actions · 2022-10-04T15:28:02Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3183394706 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

github-actions · 2022-10-04T15:39:30Z

PR test environment destroy complete (RG: rg-treca83a86f)

damoodamoo · 2022-10-04T18:08:09Z

/test-extended

github-actions · 2022-10-04T18:08:23Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3184407682 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

github-actions · 2022-10-04T18:24:50Z

PR test environment destroy complete (RG: rg-treca83a86f)

damoodamoo · 2022-10-04T19:14:54Z

/test-destroy-env

github-actions · 2022-10-04T19:15:28Z

Destroying branch test environment (RG: rg-tre5a42259b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3184813673)

github-actions · 2022-10-04T19:15:29Z

Branch test environment destroy complete (RG: rg-tre5a42259b)

github-actions · 2022-10-04T19:15:30Z

Destroying PR test environment (RG: rg-treca83a86f)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3184813673)

github-actions · 2022-10-04T19:15:32Z

PR test environment destroy complete (RG: rg-treca83a86f)

damoodamoo · 2022-10-04T19:16:11Z

/test-extended

github-actions · 2022-10-04T19:16:27Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3184821443 (with refid ca83a86f)

(in response to this comment from @damoodamoo)

…reTRE into damoo/2469-sb-out-of-order

tanya-borisova

Looks good, just had one question and I haven't read part of the diff under the assumption that it hadn't changed

api_app/services/health_checker.py

api_app/service_bus/deployment_status_update.py

damoodamoo · 2022-10-06T08:38:35Z

/test-force-approve

extended tests have previously run successfully.

github-actions · 2022-10-06T08:38:54Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 9cfbdf2)

(in response to this comment from @damoodamoo)

damoodamoo · 2022-10-06T09:11:58Z

/test-force-approve

github-actions · 2022-10-06T09:12:17Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ebc4cb0)

(in response to this comment from @damoodamoo)

damoodamoo added 7 commits September 29, 2022 17:52

sessions

979ec66

refactored and tests WIP

3a03099

tests refactored

b3c299d

Merge branch 'main' into damoo/2469-sb-out-of-order

9cb2292

api v + changelog

9c78826

rp version

4202996

core version!

dac7a2c

tanya-borisova reviewed Oct 4, 2022

View reviewed changes

Merge branch 'main' into damoo/2469-sb-out-of-order

3d8f94b

damoodamoo and others added 5 commits October 5, 2022 08:34

Merge branch 'main' into damoo/2469-sb-out-of-order

72af6fa

api version

5922fc2

Merge branch 'damoo/2469-sb-out-of-order' of github.com:microsoft/Azu…

8fcb1a1

…reTRE into damoo/2469-sb-out-of-order

Merge branch 'main' into damoo/2469-sb-out-of-order

7492263

DeploymentStatusUpdate -> DeploymentStatusUpdater

b5aa87e

tanya-borisova reviewed Oct 5, 2022

View reviewed changes

api_app/services/health_checker.py Show resolved Hide resolved

api_app/service_bus/deployment_status_update.py Outdated Show resolved Hide resolved

api_app/service_bus/deployment_status_update.py Outdated Show resolved Hide resolved

tanya-borisova reviewed Oct 5, 2022

View reviewed changes

api_app/service_bus/deployment_status_update.py Outdated Show resolved Hide resolved

daemon thread

f4a8c52

tanya-borisova approved these changes Oct 5, 2022

View reviewed changes

api_app/service_bus/deployment_status_update.py Outdated Show resolved Hide resolved

api_app/service_bus/deployment_status_update.py Outdated Show resolved Hide resolved

api_app/service_bus/deployment_status_update.py Outdated Show resolved Hide resolved

Merge branch 'main' into damoo/2469-sb-out-of-order

9cfbdf2

damoodamoo enabled auto-merge (squash) October 6, 2022 08:38

damoodamoo and others added 3 commits October 6, 2022 09:45

Merge branch 'main' into damoo/2469-sb-out-of-order

d23f06c

core v

2813d75

test fixed after renaming

ebc4cb0

damoodamoo merged commit dae21ed into main Oct 6, 2022

damoodamoo deleted the damoo/2469-sb-out-of-order branch October 6, 2022 09:12

Re-working Status Update Queue Message Handling #2700

Re-working Status Update Queue Message Handling #2700

Conversation

damoodamoo commented Oct 4, 2022 • edited Loading

Resolves #2647

What's changed:

github-actions bot commented Oct 4, 2022 • edited Loading

Unit Test Results

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

tanya-borisova left a comment

Choose a reason for hiding this comment

damoodamoo commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

damoodamoo commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

tanya-borisova left a comment

Choose a reason for hiding this comment

damoodamoo commented Oct 6, 2022

github-actions bot commented Oct 6, 2022

damoodamoo commented Oct 6, 2022

github-actions bot commented Oct 6, 2022

damoodamoo commented Oct 4, 2022 •

edited

Loading

github-actions bot commented Oct 4, 2022 •

edited

Loading