Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev container CLI install path and shared services install jq command #2725

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 11, 2022

Resolves #2724

What is being addressed

  • Makes the CLI install path relative in the dev container
  • Deploy shared services script not concerned about deployment status
  • Update CHANGELOG.md if needed

@marrobi marrobi enabled auto-merge (squash) October 11, 2022 22:35
@marrobi
Copy link
Member Author

marrobi commented Oct 11, 2022

/test

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 1c8a6e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3230701977 (with refid 8f831ecd)

(in response to this comment from @marrobi)

Copy link
Contributor

@tanya-borisova tanya-borisova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes as I think the condition in shared services script needs to be changed and not removed

devops/scripts/deploy_shared_service.sh Show resolved Hide resolved
@marrobi
Copy link
Member Author

marrobi commented Oct 12, 2022

/test-force-approve succeeded above.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 1c8a6e9)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit a533667 into microsoft:main Oct 12, 2022
@marrobi marrobi deleted the marrobi/issue2724 branch October 12, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared services pipeline install fails with 409 if status isn't deployed
3 participants