Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AML NSG fixes #2768

Merged
merged 6 commits into from
Oct 21, 2022
Merged

AML NSG fixes #2768

merged 6 commits into from
Oct 21, 2022

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 21, 2022

Resolves #2767

What is being addressed

  • Fixed incorrect variable name, and removed fail on error from bash script
  • Updated provider versions

@github-actions
Copy link

github-actions bot commented Oct 21, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 94f9769.

♻️ This comment has been updated with latest results.

@marrobi marrobi enabled auto-merge (squash) October 21, 2022 10:23
@marrobi
Copy link
Member Author

marrobi commented Oct 21, 2022

/test-force-approve AML not deployed in e2e

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 21fc2c2)

(in response to this comment from @marrobi)

Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: James Griffin <me@JamesGriff.in>
@marrobi
Copy link
Member Author

marrobi commented Oct 21, 2022

/test-force-approve

@marrobi
Copy link
Member Author

marrobi commented Oct 21, 2022

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 94f9769)

(in response to this comment from @marrobi)

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 94f9769)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 4d0e25d into microsoft:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AML deployment fails due to incorrect variable name in NSG script
2 participants