Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs around manual and automated deployment #2775

Merged
merged 17 commits into from
Nov 2, 2022
Merged

Conversation

LizaShak
Copy link
Contributor

What is being addressed

Fixes #2337
Review docs around manual and automated deployment to ensure they are clear.

How is this addressed

  • Update docs structure
  • Update env vars doc
  • Use screenshots in creating workspace/services/user/resource

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 29b668f.

♻️ This comment has been updated with latest results.

@LizaShak LizaShak changed the title Review docs around manual and automated deployment to ensure they are clear. Improve docs around manual and automated deployment Oct 24, 2022
@LizaShak LizaShak marked this pull request as ready for review October 25, 2022 15:55
Copy link
Contributor

@anastasiakuzn anastasiakuzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR since you also created a separate issue for documenting the deployment without using the github environments: #2790

@LizaShak
Copy link
Contributor Author

LizaShak commented Nov 2, 2022

/test-force-approve

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 29b668f)

(in response to this comment from @LizaShak)

@LizaShak LizaShak merged commit ea4bb73 into main Nov 2, 2022
@LizaShak LizaShak deleted the lishakur/docs-fix branch November 2, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review docs around manual and automated deployment to ensure they are clear.
5 participants