Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add missing commands and bug fixes #2784

Merged
merged 12 commits into from
Oct 28, 2022
Merged

CLI: Add missing commands and bug fixes #2784

merged 12 commits into from
Oct 28, 2022

Conversation

stuartleeks
Copy link
Contributor

@stuartleeks stuartleeks commented Oct 26, 2022 •
edited
Loading

Resolves #2706 #2707

What is being addressed

Describe the current behavior you are modifying. Please also remember to update any impacted documentation.

How is this addressed

  • Add shell completion for workspace id in get-token
  • Add --decode option to get-token command
  • Add template registration commands
  • Update register bundle script to use the CLI (additional step towards Automated validation of tre CLI #2708 )
  • Fix default table query
  • Add shared-service update/set-enabled
  • Update ACR login step in cli-package.yml

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3327938059 (with refid dbb5642e)

(in response to this comment from @stuartleeks)

@github-actions
Copy link

github-actions bot commented Oct 26, 2022 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 69c5417.

♻️ This comment has been updated with latest results.

@stuartleeks stuartleeks force-pushed the sl/cli-updates-2 branch 2 times, most recently from 6955cfd to de61baa Compare October 27, 2022 07:09
@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3335256814 (with refid dbb5642e)

(in response to this comment from @stuartleeks)

@stuartleeks
Copy link
Contributor Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3335527305 (with refid dbb5642e)

(in response to this comment from @stuartleeks)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3335527305 (with refid dbb5642e)

(in response to this comment from @stuartleeks)

@stuartleeks stuartleeks enabled auto-merge (squash) October 27, 2022 14:42
tanya-borisova
tanya-borisova approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@tanya-borisova tanya-borisova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only have two very minor comments

cli/tre/commands/shared_services/shared_service.py Show resolved Hide resolved
devops/scripts/register_bundle_with_api.sh Outdated Show resolved Hide resolved
@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3338910292 (with refid dbb5642e)

(in response to this comment from @stuartleeks)

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3340052992 (with refid dbb5642e)

(in response to this comment from @stuartleeks)

@stuartleeks
Copy link
Contributor Author

/test-force-approve

just added comment to bash script

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 69c5417)

(in response to this comment from @stuartleeks)

@stuartleeks stuartleeks merged commit 97cf9e8 into main Oct 28, 2022
@stuartleeks stuartleeks deleted the sl/cli-updates-2 branch October 28, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanya-borisova tanya-borisova tanya-borisova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure full API coverage in the tre CLI
2 participants
@stuartleeks @tanya-borisova