Add extra dns zones and links

[t-young31]

Resolves #2827

How is this addressed

• Adds extra DNS zones + links to core network

[github-actions]

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1214b09.

♻️ This comment has been updated with latest results.

[t-young31]

@microsoft-github-policy-service agree [company="UCL"]

[t-young31]

@microsoft-github-policy-service agree company="UCL"

[tamirkamara]

DNS zones are taking more time in the deployment, so I just want to know if other options have been considered... Depending how the azure services are planned to be deployed it might be possible to use shared services for this?

[t-young31]

Depending how the azure services are planned to be deployed it might be possible to use shared services for this?

good question – not sure. will need @marrobi 's input

[marrobi]

Depending how the azure services are planned to be deployed it might be possible to use shared services for this?

good question – not sure. will need @marrobi 's input

Each one could be done as a separate shared service, or could do something similar to what I've done with External URI, single shared service, can be deployed multiple time with different DNS zone name. or even an array? PR is open, and @tanya-borisova is looking at how to handle singleton services as part of #2820 .

The other option is we have an environment variable with a list of all the DNS zones passed into the core deployment.

@tamirkamara thoughts? A single DNS zones shared service with array is maybe a nice solution for these "optional" DNS zones.

[marrobi]

Also worth noting @t-young31 has followed the approach used for AML, so maybe merge this and then take the "improved" approach, as a new issue?

[marrobi]

One more thing, if it was a single shared service with an array, a pipeline in the workspace could add the DNs zones as per the same method used for firewall rules.

[tamirkamara]

A single DNS zones shared service with array is maybe a nice solution for these "optional" DNS zones.

Yes, something like this. Another approach to the lack of state for the core system, is to add a shared service exactly for that, something like common state (store) and have the pipeline procedure interact with it. It seems a bit "hacky" but will work...

[tamirkamara]

/test 1214b09

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3417386577 (with refid 3e9c17cf)

(in response to this comment from @tamirkamara)

[tamirkamara]

/test-extended 1214b09

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3418057109 (with refid 3e9c17cf)

(in response to this comment from @tamirkamara)