Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource templateVersion update #2908

Merged

Conversation

guybartal
Copy link
Contributor

Resolves #1744

What is being addressed

Add support for resource version updates.

How is this addressed

  • add templateVersion and 'forceVersionUpdate' properties to ResourcePatch model
  • update resource template version in cosmos db
  • block major version updates
  • block version downgrades
  • update github PR template
  • Update documentation
  • Update CHANGELOG.md if needed

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3542131615 (with refid d346fd55)

(in response to this comment from @guybartal)

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Unit Test Results

538 tests   538 ✔️  15s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit fde4d3e.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to finally see this!

api_app/_version.py Outdated Show resolved Hide resolved
api_app/models/schemas/resource.py Outdated Show resolved Hide resolved
api_app/api/routes/shared_services.py Outdated Show resolved Hide resolved
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:42 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 16:43 Inactive
@tamirkamara
Copy link
Collaborator

/test-extended

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3614589339 (with refid d346fd55)

(in response to this comment from @tamirkamara)

@guybartal guybartal merged commit 21caf4c into microsoft:main Dec 4, 2022
marrobi pushed a commit to marrobi/AzureTRE that referenced this pull request Dec 6, 2022
* resource update mechanism

Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants