Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guacamole restrictions #2967

Merged
merged 12 commits into from
Jan 12, 2023
Merged

add guacamole restrictions #2967

merged 12 commits into from
Jan 12, 2023

Conversation

eladiw
Copy link
Contributor

@eladiw eladiw commented Dec 15, 2022

What is being addressed

Configure guacamole to have stricter rules

How is this addressed

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3702566079 (with refid 2adfed63)

(in response to this comment from @eladiw)

@github-actions
Copy link

github-actions bot commented Dec 15, 2022 •
edited
Loading

Unit Test Results

15 tests   15 ✔️  2s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit 63494d8.

♻️ This comment has been updated with latest results.

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3702882254 (with refid 2adfed63)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre2adfed63)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3703204646)

@github-actions
Copy link

Destroying branch test environment (RG: rg-tre00261096)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3703204646)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tre00261096)

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3703212769 (with refid 2adfed63)

(in response to this comment from @eladiw)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre2adfed63)

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3703554607 (with refid 2adfed63)

(in response to this comment from @eladiw)

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre2adfed63)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3704150929)

@github-actions
Copy link

Destroying branch test environment (RG: rg-tre00261096)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3704150929)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tre00261096)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre2adfed63)

@eladiw
Copy link
Contributor Author

eladiw commented Dec 15, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3705971249 (with refid 2adfed63)

(in response to this comment from @eladiw)

@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:06 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:06 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:06 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:06 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:06 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:12 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:13 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:13 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:13 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:13 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:14 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:15 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:15 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:15 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:15 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:17 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 16:18 — with GitHub Actions Inactive
@anatbal
Copy link
Collaborator

anatbal commented Jan 12, 2023

https://github.com/microsoft/AzureTRE/actions/runs/3896064292
Passed

@anatbal
Copy link
Collaborator

anatbal commented Jan 12, 2023

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 63494d8)

(in response to this comment from @anatbal)

@anatbal anatbal enabled auto-merge (squash) January 12, 2023 16:43
@anatbal anatbal merged commit 341cecd into main Jan 12, 2023
@anatbal anatbal deleted the fix/disabledownload branch January 12, 2023 16:43
@anatbal anatbal temporarily deployed to CICD January 12, 2023 17:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara left review comments

@marrobi marrobi marrobi approved these changes

@anatbal anatbal anatbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eladiw @anatbal @marrobi @tamirkamara