Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Porter to v1 #3014

Merged
merged 4 commits into from
Dec 26, 2022
Merged

Upgrade Porter to v1 #3014

merged 4 commits into from
Dec 26, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Dec 26, 2022

Resolves #2755, Resolves #1828

What is being addressed

Porter v1 has been released recently and we need to upgrade.

How is this addressed

Many small changes were made to support this upgrade. You can review the notes on the separate PRs comprising this one.

You are required to upgrade any existing template - edit its definition per the new schema (use any template in this repo as an example), and register a new version for all templates you're using.

@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Unit Test Results

538 tests   538 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 4d60e70.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3780421538 (with refid b02c7295)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3780421538 (with refid b02c7295)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3781052944 (with refid b02c7295)

(in response to this comment from @tamirkamara)

* porter v1 core

* cr changes

* some fixes

* workflow triggers

* api version

* include porter's config.yaml
* templates change for porter v1

* fix exit code when retrying

* fix guacamole

* certbot doesn't need to install python

* debug porter explain

* cleanup

* lint

* rp version

* cr comments

* fix base workflow conflict
update docs for porter v1
@tamirkamara
Copy link
Collaborator Author

/test-force-approve
A successful run: https://github.com/microsoft/AzureTRE/actions/runs/3781052944

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 4d60e70)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) December 26, 2022 13:06
@tamirkamara tamirkamara merged commit 2869309 into main Dec 26, 2022
@tamirkamara tamirkamara deleted the feature/porter-v1 branch December 26, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants