Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AML to enable private IP compute #3052

Merged
merged 29 commits into from
Jan 25, 2023
Merged

Update AML to enable private IP compute #3052

merged 29 commits into from
Jan 25, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jan 4, 2023 •
edited
Loading

Fixes #2780, #2971, #1846

What is being addressed

Update AML workspace to cover Private IP compute scenario

How is this addressed

  • Update AML TF resource
  • amend networking for additional address space and update firewall/network rules
  • Update documentation
  • Update CHANGELOG.md if needed

Follow on work

@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d8ae302.

♻️ This comment has been updated with latest results.

@marrobi marrobi linked an issue Jan 4, 2023 that may be closed by this pull request
Creating Workspace from ML Template #2971
Closed
@marrobi
Copy link
Member Author

marrobi commented Jan 17, 2023

@damoodamoo are you or one of your team still intending to take this forward? It is now usable, however a couple of outstanding issues as detailed above.

@tamirkamara if you can give this a first pass (still draft) would eb appreciated.

tamirkamara
tamirkamara reviewed Jan 18, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
core/terraform/storage.tf Outdated Show resolved Hide resolved
templates/workspace_services/azureml/template_schema.json Outdated Show resolved Hide resolved
templates/workspace_services/azureml/terraform/compute.tf Show resolved Hide resolved
templates/workspace_services/azureml/terraform/outputs.tf Show resolved Hide resolved
@marrobi marrobi marked this pull request as ready for review January 24, 2023 16:13
@marrobi
Copy link
Member Author

marrobi commented Jan 25, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4005077826 (with refid 4c32c663)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) January 25, 2023 13:35
@marrobi
Copy link
Member Author

marrobi commented Jan 25, 2023

/test-force-approve

Passed: https://github.com/microsoft/AzureTRE/actions/runs/4005077826

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit d8ae302)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit d167dae into microsoft:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara approved these changes

@damoodamoo damoodamoo Awaiting requested review from damoodamoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating Workspace from ML Template Cannot create private AML compute
2 participants
@marrobi @tamirkamara