Migrate reviewDecision of Airlock Reviews #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladiw
reviewed
Jan 31, 2023
eladiw
reviewed
Jan 31, 2023
…com/yuvalyaron/AzureTRE into 3121-migrate-airlock-reviewdecision
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4053761165 (with refid (in response to this comment from @yuvalyaron) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4053804149 (with refid (in response to this comment from @yuvalyaron) |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4053804149 (with refid (in response to this comment from @yuvalyaron) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3121
What is being addressed
Airlock reviews used to have one of these values:
approval_in_progressandrejection_in_progress.But since #2670 , instead of using these values, we use
approvedandrejected,This causes API type errors when trying to GET requests that have been created with older TRE versions, as these contain the older values.
How is this addressed