Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker in docker support from RP #3180

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3179

What is being addressed

We used to have bundles requiring docker-in-docker support. This is no longer the case and we don't need to allow porter to access docker on the host.

How is this addressed

  • Update how the RP calls porter actions
  • Update make target that include porter actions
  • [tiny unrelated] move a noisy log to debug as it's normal behavior

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 625a06f.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4066217950 (with refid b5e650fe)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Destroying PR test environment (RG: rg-treb5e650fe)... (run: https://github.com/microsoft/AzureTRE/actions/runs/4067698062)

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Destroying branch test environment (RG: rg-tre54776ff1)... (run: https://github.com/microsoft/AzureTRE/actions/runs/4067698062)

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Branch test environment destroy complete (RG: rg-tre54776ff1)

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

PR test environment destroy complete (RG: rg-treb5e650fe)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4072269525 (with refid b5e650fe)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 750fad8 into main Feb 2, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3179-rp-remove-dind branch February 2, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Resource Processor support of Docker-in-Docker
2 participants