Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auth private endpoint from databricks workspace service #3199

Conversation

guybartal
Copy link
Contributor

@guybartal guybartal commented Feb 6, 2023

Resolves partially #3182 and related to #3122

What is being addressed

  • Removing auth private endpoint from Databricks workspace service as it should be deployed only once per region.
    A separate PR will be created to deploy it with Databricks shared service.

  • Follow recommended configuration by Databricks see scenario table.

  • Consolidating connection_uri and internal_connection_uri into single output which will be rendered in UI according to is_exposed_externally.

How is this addressed

  • Removing auth private endpoint from Databricks workspace service.
  • Always return adb connection url as connection_uri.
  • Set network_security_group_rules_required to NoAzureDatabricksRules according to recommended configuration by Databricks .

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 07dad08.

♻️ This comment has been updated with latest results.

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4104784085 (with refid b9c34092)

(in response to this comment from @guybartal)

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4106020497 (with refid b9c34092)

(in response to this comment from @guybartal)

@guybartal
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4107826850 (with refid b9c34092)

(in response to this comment from @guybartal)

@guybartal guybartal merged commit d245319 into microsoft:main Feb 6, 2023
@guybartal guybartal deleted the guybartal/remove-auth-pe-from-adb-ws-service branch February 6, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants