Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unique step id for each OperationStep #3239

Merged
merged 12 commits into from
Feb 28, 2023
Merged

Conversation

anatbal
Copy link
Collaborator

@anatbal anatbal commented Feb 22, 2023

Resolves #3213

What is being addressed

Since each stepId in the template object is hard coded, it created clashes when cascade disabling/deleting the same type of object (for example ws service). This PR creates a unique id for each operation step.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

Unit Test Results

572 tests   572 ✔️  13s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit c867705.

♻️ This comment has been updated with latest results.

@anatbal
Copy link
Collaborator Author

anatbal commented Feb 22, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4242578659 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@anatbal anatbal requested a review from eladiw February 22, 2023 12:29
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4242578659 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Feb 23, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4250756010 (with refid 7c576f7d)

(in response to this comment from @anatbal)

2 similar comments
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4250756010 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4250756010 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@tamirkamara
Copy link
Collaborator

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4252889258 (with refid 7c576f7d)

(in response to this comment from @tamirkamara)

@anatbal
Copy link
Collaborator Author

anatbal commented Feb 27, 2023

/test-extended

@anatbal anatbal enabled auto-merge (squash) February 27, 2023 14:49
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4283635494 (with refid 7c576f7d)

(in response to this comment from @anatbal)

2 similar comments
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4283635494 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4283635494 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@anatbal
Copy link
Collaborator Author

anatbal commented Feb 27, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4285755026 (with refid 7c576f7d)

(in response to this comment from @anatbal)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4285755026 (with refid 7c576f7d)

(in response to this comment from @anatbal)

@anatbal anatbal merged commit 61737f3 into main Feb 28, 2023
@anatbal anatbal deleted the feature/change-stepId branch February 28, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running a pipeline for two different resources of the same type fails
3 participants