Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RP_BUNDLE_VALUES to PR Bot #3368

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

The RP_BUNDLE_VALUES parameter was missing when a deployment was started by the PR bot.

@tamirkamara tamirkamara marked this pull request as draft March 27, 2023 08:12
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4530192753 (with refid 6adcca9b)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

github-actions bot commented Mar 27, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 810296e.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4530608270 (with refid 6adcca9b)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4530781266 (with refid 6adcca9b)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test cd45bd2

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4530797039 (with refid 6adcca9b)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4530828525 (with refid 6adcca9b)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara force-pushed the tamirkamara/fix-pr-bot-rp-values branch from 582917f to 810296e Compare March 27, 2023 09:41
@tamirkamara tamirkamara marked this pull request as ready for review March 27, 2023 09:41
@tamirkamara
Copy link
Collaborator Author

/test-force-approved
Changes in the workflow files can't be tested via the bot.

@github-actions
Copy link

🤖 pr-bot 🤖

/test-force-approved is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
Changes in the workflow files can't be tested via the bot.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 810296e)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) March 27, 2023 09:51
@tamirkamara tamirkamara merged commit 8b8ca36 into main Mar 27, 2023
@tamirkamara tamirkamara deleted the tamirkamara/fix-pr-bot-rp-values branch March 27, 2023 09:54
LizaShak added a commit that referenced this pull request Mar 28, 2023
* Fix firewall log categories (#3313)

fix firewall log categories

* Add question template (#3327)

* Add question template

* update databricks diagram (#3337)

* RP_BUNDLE multiple values fix (#3343)

* added spacing to join and some test rp_bundle vals to the build to ensure breaks if it needs to

* bumped core v

* rp_bundles to secret

* Fix ENABLE_SWAGGER in CI (#3355)

* change ENABLE_SWAGGER to TF_VAR_enable_swagger, and make it false by default

* update changelog

* Add RP_BUNDLE_VALUES to PR Bot (#3368)

Add RP_BUNDLE_VALUES to pr-bot

* Migration for stepId in OperationSteps (#3358)

* add migration for operationStep

* update PR name

* Add 'availableUpgrades' field to Resources (#3234)

* add availableUpgrades field to resources

* enrich resources with availableUpgrades in endpoints

* rename AvailableUpgrades fields

* fix tests

* fix types

* rename variable

* add tests for enrich_resource_with_available_upgrades

* update api version and changelog

* change structure of resource available upgrades

* Dependabot UI updates (#3370)

* Bump @azure/msal-browser from 2.32.1 to 2.33.0 in /ui/app

Bumps [@azure/msal-browser](https://github.com/AzureAD/microsoft-authentication-library-for-js) from 2.32.1 to 2.33.0.
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-js/releases)
- [Commits](AzureAD/microsoft-authentication-library-for-js@msal-browser-v2.32.1...msal-browser-v2.33.0)

---
updated-dependencies:
- dependency-name: "@azure/msal-browser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @testing-library/react from 13.4.0 to 14.0.0 in /ui/app

Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 13.4.0 to 14.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v13.4.0...v14.0.0)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @fluentui/react from 8.105.1 to 8.106.1 in /ui/app

Bumps [@fluentui/react](https://github.com/microsoft/fluentui) from 8.105.1 to 8.106.1.
- [Release notes](https://github.com/microsoft/fluentui/releases)
- [Changelog](https://github.com/microsoft/fluentui/blob/master/azure-pipelines.release-fluentui.yml)
- [Commits](https://github.com/microsoft/fluentui/compare/@fluentui/react_v8.105.1...@fluentui/react_v8.106.1)

---
updated-dependencies:
- dependency-name: "@fluentui/react"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @types/node from 18.11.9 to 18.14.2 in /ui/app

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.9 to 18.14.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump webpack from 5.75.0 to 5.76.1 in /ui/app

Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.75.0...v5.76.1)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adjust versions

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Co-authored-by: Marcus Robinson <marrobi@microsoft.com>
Co-authored-by: Guy Bertental <guybartal@gmail.com>
Co-authored-by: David Moore <35696285+damoodamoo@users.noreply.github.com>
Co-authored-by: Yuval Yaron <43217306+yuvalyaron@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants