Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock Notifier - Change SMTP connector type #3573

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

SharonHart
Copy link
Contributor

@SharonHart SharonHart commented Jun 14, 2023

Resolves #3572

What is being addressed

After SMTP connector became GA in Azure Logic Apps, terraform deployment can now be simplified to not use plain ARM for the smtp api connection deployment

How is this addressed

  • Remove api connector arm json definitions
  • Change logic app connections.json to point at the new built in connector, configured with app settings.

@SharonHart SharonHart marked this pull request as ready for review June 14, 2023 08:45
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 88d336b.

♻️ This comment has been updated with latest results.

@SharonHart
Copy link
Contributor Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit f9aaee1)

(in response to this comment from @SharonHart)

Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SharonHart!

@SharonHart
Copy link
Contributor Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 88d336b)

(in response to this comment from @SharonHart)

@SharonHart
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5275823668 (with refid cb065e31)

(in response to this comment from @SharonHart)

@SharonHart
Copy link
Contributor Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 88d336b)

(in response to this comment from @SharonHart)

@SharonHart SharonHart enabled auto-merge (squash) June 15, 2023 07:57
@SharonHart SharonHart merged commit 0ed36d0 into main Jun 15, 2023
@SharonHart SharonHart deleted the shhart/feature/change-notifier-smtp-connector branch June 15, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Airlock Notifier SMTP to a built-in connector
2 participants