Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications how workspace details, rather than the actual resource #3747

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 16, 2023

Fixes #3746

Fix logic that decides when notification is for a workspace vs workspace item.

@marrobi marrobi enabled auto-merge (squash) October 16, 2023 15:33
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit e7378a2.

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, nice catch

@marrobi
Copy link
Member Author

marrobi commented Oct 17, 2023

/test-force-approve

UI only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e7378a2)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit a7436dd into microsoft:main Oct 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications how workspace details, rather than the actual resource
2 participants